Netapp volumes: Add restoreParameters #17293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add force delete to delete volumes with nested snapshots * few cleanups * Make virtual field verifies happy * Minor test improvements * Remove ignore_read for deletion_policy * Fix typos in snapRestore comment * Adding missing fields state, StateDetails, backupConfig * BackupConfig is work in progress * Implemented restoreParameters - added parameters state and state_details. Needs discussion if they are to be included. Currently they are deactivated - added restore_parameters. - added test for restore_parameters.source_snapshot - adding a test for restore_parameters.sourceBackup required currently non-existing backup resoruce and would have long runtime - renamed the example file to follow format of other peer resources * More improvements on restore_parameters * Comment cleanups * Remove backupConfig support for now. * Fix small typos * - Adding state, state_details and create_time fields - make backup_config parameters "exactly_one_of" - some work on backup_config, but still disabled - added tests for backup_config, but still disabled - made tests more compact by removing resources and fields which did their job earlier but aren't required later anymore. * convert tabs to spaces in test resource blocks * remove backupConfig. Will PR later [upstream:44e139bad1261704549ac95150b5b666ff790528] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the next stop on adding functionality to the google_netapp_volume resource. It adds support for restoreParameters which are two features:
It also does some cleanup on comments and file renames for better consistency.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9918